-
-
Notifications
You must be signed in to change notification settings - Fork 48
Cmake & Code formatting #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Disable automatic git eol conversion in .gitattributes * Add clang-format configuration * Add pre-commit formatting hooks
|
Having to port my branches over once will be worth having consistent line endings across the repo ;) |
|
|
||
|
|
||
| # Generate hex file (SDCC) | ||
| if (${CMAKE_C_COMPILER} STREQUAL "sdcc" OR ${TARGET_CONTROLLER} STREQUAL "BBS02" OR ${TARGET_CONTROLLER} STREQUAL "TSDZ2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look further into the file, but should this line have BBSHD too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye that's wrong, thanks!
|
The command for sdcc doesn't seem to work correctly on windows, I've confirmed both the above work on windows and linux. |
|
Also, $(shell etc...) doesn't seem to work on linux, so this change fixes that (badly, I'm sure there's some nicer way to do this, I'm just not sure what would also work on a raspberry pi) under the uname setup, added: edit: please let me know if you want a diff or branch with these changes on. I figure as it's only a couple of lines it's just easier to add to the PR branch |
Visual Studio Code is now the preferred editor with cross platform support.
I realize these changes are going to cause some pain for those of you who are maintaining your own fork of this repository but it is much needed and will make future work easier.