Skip to content

Conversation

@danielnilsson9
Copy link
Owner

@danielnilsson9 danielnilsson9 commented Mar 15, 2025

  • Switch to CMake as build system for firmware to prepare for TSDZ8 port using different compiler.
  • Add pre-commit file formatting hooks (eol etc).
  • Add clang-format configuration.

Visual Studio Code is now the preferred editor with cross platform support.

I realize these changes are going to cause some pain for those of you who are maintaining your own fork of this repository but it is much needed and will make future work easier.

* Disable automatic git eol conversion in .gitattributes
* Add clang-format configuration
* Add pre-commit formatting hooks
@EigenMania
Copy link
Contributor

Having to port my branches over once will be worth having consistent line endings across the repo ;)



# Generate hex file (SDCC)
if (${CMAKE_C_COMPILER} STREQUAL "sdcc" OR ${TARGET_CONTROLLER} STREQUAL "BBS02" OR ${TARGET_CONTROLLER} STREQUAL "TSDZ2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look further into the file, but should this line have BBSHD too?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye that's wrong, thanks!

@davejupp
Copy link

The command for sdcc doesn't seem to work correctly on windows,
INC_DIRS = -I./. $(addprefix -I, $(SUBDIRS))
works correctly. Or
INC_DIRS = -I. $(addprefix -I, $(SUBDIRS))

I've confirmed both the above work on windows and linux.

@davejupp
Copy link

davejupp commented Jun 10, 2025

Also, $(shell etc...) doesn't seem to work on linux, so this change fixes that (badly, I'm sure there's some nicer way to do this, I'm just not sure what would also work on a raspberry pi)

under the uname setup, added:

ifndef UNAME
    UNAME := (uname 2>/dev/null || echo Unknown)
endif

edit: please let me know if you want a diff or branch with these changes on. I figure as it's only a couple of lines it's just easier to add to the PR branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants