fix(installer): scope chmod to shebang scripts instead of chmod -R 755#1090
Open
keegoid wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix(installer): scope chmod to shebang scripts instead of chmod -R 755#1090keegoid wants to merge 1 commit intodanielmiessler:mainfrom
keegoid wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
The configuration step runs `chmod -R 755` on the entire paiDir, which flips every .md, .json, .yaml, .txt (etc.) under ~/.claude to executable. Users who manage ~/.claude under git see this as thousands of mode-only diffs on every upgrade. Replace the blanket chmod with a targeted walk that only sets +x on (a) files ending in .sh, and (b) files with a common script extension (.ts/.js/.mjs/.cjs/.py) whose first two bytes are '#!'. Everything else is left at whatever mode the filesystem / cp gave it. Skips .git and node_modules during the walk. All chmod errors and unreadable files are ignored (non-fatal, matching the original try/catch around the chmod block). Verified: type-checks with bun; unit-run against a synthetic tree flips only scripts, no data files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration step runs
chmod -R 755on the entire paiDir, flipping every .md/.json/.yaml/.txt under ~/.claude to executable. Users who manage ~/.claude under git see thousands of mode-only diffs on every upgrade.This replaces the blanket chmod with a targeted walk that only sets +x on (a) files ending in .sh, and (b) files with a common script extension (.ts/.js/.mjs/.cjs/.py) whose first two bytes are '#!'. Everything else is left alone.
Skips .git and node_modules. All chmod errors and unreadable files are ignored (non-fatal, matching the original try/catch semantics).
Verified: bun type-check passes; unit-run against a synthetic tree flips only scripts, no data files.