Fix duplicate Date header and add return path config#100
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses outbound email correctness by preventing duplicate Date headers on forwarded messages and introducing a configurable SMTP envelope sender (Return-Path) separate from the From address.
Changes:
- Fixes
Dateheader handling when creating forwardedMimeMessageinstances to avoid duplicates. - Adds
EmailDelivery:ReturnPathconfiguration (plus documentation) and uses it for the SMTP envelope sender. - Updates various dependency versions (webapp packages, NSwag, test SDK).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/package.json | Bumps webapp version and updates several frontend dependencies. |
| webapp/package-lock.json | Lockfile updates reflecting the dependency upgrades. |
| server/Mailist/appsettings.json | Adds EmailDelivery.ReturnPath default setting. |
| server/Mailist/Mailist.csproj | Updates NSwag.AspNetCore package version. |
| server/Mailist/EmailRelay/MimeMessageCreationService.cs | Changes Date header assignment to avoid duplication. |
| server/Mailist/EmailDelivery/EmailDeliveryOptions.cs | Adds ReturnPath option to delivery configuration. |
| server/Mailist/EmailDelivery/EmailDeliveryJobController.cs | Uses ReturnPath (if set) as SMTP envelope sender. |
| server/Mailist.Tests/Mailist.Tests.csproj | Updates Microsoft.NET.Test.Sdk version. |
| docs/configuration.md | Documents EmailDelivery__ReturnPath. |
Files not reviewed (1)
- webapp/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug which caused all delivered emails to have a duplicate Date header. Furthermore, it is now possible to configure a separate address for Return-Path other than the From address.