Skip to content

Fix duplicate Date header and add return path config#100

Merged
daniel-lerch merged 2 commits into
masterfrom
date-header
Apr 14, 2026
Merged

Fix duplicate Date header and add return path config#100
daniel-lerch merged 2 commits into
masterfrom
date-header

Conversation

@daniel-lerch
Copy link
Copy Markdown
Owner

This pull request fixes a bug which caused all delivered emails to have a duplicate Date header. Furthermore, it is now possible to configure a separate address for Return-Path other than the From address.

@daniel-lerch daniel-lerch requested a review from Copilot April 14, 2026 07:30
@daniel-lerch daniel-lerch self-assigned this Apr 14, 2026
@daniel-lerch daniel-lerch added the bug Something isn't working label Apr 14, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses outbound email correctness by preventing duplicate Date headers on forwarded messages and introducing a configurable SMTP envelope sender (Return-Path) separate from the From address.

Changes:

  • Fixes Date header handling when creating forwarded MimeMessage instances to avoid duplicates.
  • Adds EmailDelivery:ReturnPath configuration (plus documentation) and uses it for the SMTP envelope sender.
  • Updates various dependency versions (webapp packages, NSwag, test SDK).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
webapp/package.json Bumps webapp version and updates several frontend dependencies.
webapp/package-lock.json Lockfile updates reflecting the dependency upgrades.
server/Mailist/appsettings.json Adds EmailDelivery.ReturnPath default setting.
server/Mailist/Mailist.csproj Updates NSwag.AspNetCore package version.
server/Mailist/EmailRelay/MimeMessageCreationService.cs Changes Date header assignment to avoid duplication.
server/Mailist/EmailDelivery/EmailDeliveryOptions.cs Adds ReturnPath option to delivery configuration.
server/Mailist/EmailDelivery/EmailDeliveryJobController.cs Uses ReturnPath (if set) as SMTP envelope sender.
server/Mailist.Tests/Mailist.Tests.csproj Updates Microsoft.NET.Test.Sdk version.
docs/configuration.md Documents EmailDelivery__ReturnPath.
Files not reviewed (1)
  • webapp/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/Mailist/EmailDelivery/EmailDeliveryJobController.cs
Comment thread server/Mailist/EmailRelay/MimeMessageCreationService.cs
Comment thread webapp/package.json
@daniel-lerch daniel-lerch merged commit 4e09b04 into master Apr 14, 2026
3 checks passed
@daniel-lerch daniel-lerch deleted the date-header branch April 14, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants