refactor: replace get-stdin with native stream/consumers module #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbartho
approved these changes
May 15, 2025
|
I don’t normally hit the Merge button on PRs other than my own, as I don’t believe I have publish/deploy capabilities for DangerJS. Usually @orta ships maintenance patches & features as a batch, and there haven’t been any other feature or maintenance changes merged for DangerJS in 4 months. @baevm is there any urgency or time-sensitivity on this patch? I would expect it to land in our next release, whenever that happens. |
|
Lets at least get this in, and then when something else arrives it will be a part of the process 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Since danger-js targets node >= 18, get-stdin can be replaced with native stream/consumers module
reference: https://github.com/sindresorhus/get-stdin?tab=readme-ov-file#tip