chore: Upgrade @octokit/rest for CVE patch - no-ESM mitigation patch - Fixes #1479 #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- v19 dropped support for node 10/12 (https://github.com/octokit/rest.js/releases/tag/v19.0.0) - v20 dropped support for node 14/16, removed preview support for the REST API, and removed the agent option (https://github.com/octokit/rest.js/releases/tag/v20.0.0) - v21 updated the package to ESM (https://github.com/octokit/rest.js/releases/tag/v21.0.0) None of these breaking changes should impact v12 of danger-js as it requires node >= 18.
Hate this field.
This is a build-tool so doesn't affect our users, but it does prevent casual CI testing on Node 18.
|
@orta Appveyor appears to be failing the CI, even though all the tests passed, and there's no reported error messages |
|
Eh, I can live with the appveyor builds being red |
orta
approved these changes
Mar 15, 2025
|
Hello folks -- how do we progress landing this fix? |
|
+1 to the above - any updates? Looks like the green light has been given |
|
@justinc324 @mikehall314 I've merged it, but I don't have permissions to package and ship a release, so it'll go out when that next happens. In the meantime, you could directly reference the SHA in your package version selectors, I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative PR for: #1477
Fixes: #1479
Fixes transitive CVE: GHSA-h5c3-5r3r-rr8q
Contents
"^20.9.0 || >=22.0.0". I could tweak CI to install with node-20, and then run it with node 18, but that seems messy/risky/low-value.This kicks the can down the road on our migration to ESM.