TEMP: sketch on api.tf on what common variables to vendorize and where to pass #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to pass Potentially we need to - define instance varaibles in variables.tf, not hardcode in api.tf and staging_pipeline.tf - we already pass different terraform variables for DOI service auth
yarikoptic
commented
May 28, 2025
asmacdo
reviewed
May 28, 2025
| DJANGO_DANDI_DOI_API_URL = "https://api.datacite.org/dois" | ||
| DJANGO_DANDI_DOI_API_USER = "dartlib.dandi" | ||
| DJANGO_DANDI_DOI_API_PREFIX = "10.48324" | ||
| DJANGO_DANDI_DOI_API_PREFIX = "10.${var.dandi_instance_datacite_id}" |
Member
There was a problem hiding this comment.
Nitpick: It is reasonable to hardcode the 10. since IIUC thats a universal for dois. However, IMO i think it will be friendlier to configure if the var would be set to 10.12345 because the full value is what is defined as "your prefix" from datacite. https://doi.test.datacite.org/repositories/dartlib.dandi/prefixes
yarikoptic
commented
May 30, 2025
| # TODO: move to variables.tf? | ||
| dandi_instance_name = "dandi" | ||
| dandi_instance_tld = "dandiarhive.org" | ||
| dandi_instance_datacite_id = "48324" |
Member
Author
There was a problem hiding this comment.
those likely should be moved out into terraform/variables.tf
Member
|
@yarikoptic If there is no action plan or effort being put towards this PR please close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially we need to