Skip to content

2438 favorite follow list#3192

Closed
askeew wants to merge 1 commit into
damus-io:masterfrom
askeew:2438-favorite-follow-list
Closed

2438 favorite follow list#3192
askeew wants to merge 1 commit into
damus-io:masterfrom
askeew:2438-favorite-follow-list

Conversation

@askeew
Copy link
Copy Markdown
Contributor

@askeew askeew commented Aug 14, 2025

Summary

Implementing Favourite list: #2438 using NIP-51

  • renamed follow_list -> starter_list
  • renamed list_deprecated = 30000 -> follow_list
  • ignoring old follow_list with deprecated mute

Checklist

  • I have read (or I am familiar with) the Contribution Guidelines
  • I have tested the changes in this PR
  • I have opened or referred to an existing github issue related to this change.
  • My PR is either small, or I have split it into smaller logical commits that are easier to review
  • I have added the signoff line to all my commits. See Signing off your work
  • I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
    • I do not need to add a changelog entry. Reason: [Please provide a reason]
  • I have added appropriate Closes: or Fixes: tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches

Test report

Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.

Results:

  • PASS
  • Partial PASS

Other notes

This PR is based on NIP-51. We will probably want to use NIP-81 Contact Cards instead. I will do that PR next.

@alltheseas
Copy link
Copy Markdown
Collaborator

@jb55 mentions nostr-protocol/nips#761

@askeew askeew force-pushed the 2438-favorite-follow-list branch 2 times, most recently from d3db8b5 to a00bdd6 Compare August 25, 2025 13:21
…ine for favorited users.

Closes: damus-io#2438
Changelog-Added: Favorite list via NIP-51
Signed-off-by: Askia <askeew@hotmail.com>
@askeew askeew force-pushed the 2438-favorite-follow-list branch from a00bdd6 to 2a775b9 Compare August 25, 2025 13:21
@askeew askeew marked this pull request as ready for review August 25, 2025 13:24
@danieldaquino danieldaquino self-requested a review August 26, 2025 01:54
@danieldaquino
Copy link
Copy Markdown
Collaborator

Thanks @askeew, I will review this sometime soon.

@askeew
Copy link
Copy Markdown
Contributor Author

askeew commented Aug 26, 2025

Thanks @askeew, I will review this sometime soon.

I will close this one, I'll create a new PR with NIP-81 instead of NIP-51

@askeew askeew closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants