Add linting scripts and run linter #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbackman
force-pushed
the
mb/fix-linting
branch
3 times, most recently
from
741d196 to
f064ee0
Compare
cbrianhill
approved these changes
Dec 22, 2025
Contributor
cbrianhill
left a comment
cbrianhill
left a comment
There was a problem hiding this comment.
This looks good to me. One question: should we add a short blurb to the readme to let people know when hacking on this that they should install pre-commit and configure it with git?
markbackman
force-pushed
the
mb/fix-linting
branch
from
f064ee0 to
9968be1
Compare
Contributor
Author
Good idea. Just added those steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two scripts:
Also, adds .pre-commit-config.yaml to pyproject.toml, so linting is checked with each commit.
Finally, I ran
fix-ruff.shand then did manual clean up after to resolve all linting issues. 😌