Skip to content

Unify Font Size In Search Result Dock #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kolcz
Copy link
Contributor

@kolcz kolcz commented Jul 12, 2025

Description

This PR addresses issue #827. In this PR I made font, in SearchResultsDock to match application settings parameters during initialization and when font is changed in PreferencesDialog.

Changes Made

  • Remove setting different font size on MacOS,
  • Add setFont() method to SearchResultsDock,
  • Added running setFont after SearchResultsDock initialization,
  • Connect ApplicationSettings::fontNameChanged and ApplicationSettings::fontSizeChanged to setFont method.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change
  • Documentation update

Testing - on Windows 11 and Debian 12 bookworm

  • Font in SearchResultsDock, Editor are the same during initialization and identical to font specified in PreferencesDialog,
  • After changing font size by clicking arrows, both fonts in Editor and SearchResultsDock are modified,
  • After changing font size by typing new value, both fonts in Editor and SearchResultsDock are modified,
  • After changing font family by selecting from the list, both fonts in Editor and SearchResultsDock are changed,
  • After changing font family by typing new value, both fonts in Editor and SearchResultsDock are changed.

Additional Note

Someone need to test it on MacOS.

@kolcz kolcz marked this pull request as draft July 12, 2025 18:00
@dail8859
Copy link
Owner

Thanks for this!

I think this is a good first step. It would be best to also go ahead and always set the font of the tree view to the default font and size that is specified in the ApplicationSettings. This can be changed in the future but it's a logical step so that things will be consistent.

@kolcz
Copy link
Contributor Author

kolcz commented Jul 13, 2025

You're welcome. :)
Yeah, sure. Good idea! I was a little surprised when I found out that Debian by default has font "Liberation Mono" with size 12, so it will be a good idea to unify that.

@kolcz kolcz marked this pull request as ready for review July 18, 2025 21:35
@kolcz kolcz marked this pull request as draft July 18, 2025 21:40
@kolcz kolcz marked this pull request as ready for review July 18, 2025 21:40
@kolcz
Copy link
Contributor Author

kolcz commented Jul 18, 2025

@dail8859 Could you take a look at changes? I can't request a review by github now. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants