Skip to content

Conversation

@CrispyCrafter
Copy link

Summary & Motivation

This PR extends the existing functionality of both dagster-webserver and dagster-daemon helm templates by unlocking the ability to select the logformat generated by either service. This is especially helpful when integrating with third-party logging services such as DataDog and Loki.

How I Tested These Changes

Changes tested and rolled out in live production environment.

@cmpadden
Copy link
Contributor

Thanks @CrispyCrafter, it looks like it's defaulting to providing the --log-format colored flag which is causing a couple of tests to fail. You could either update your changes so that it defaults to no flag (probably cleanest), or update the tests to accommodate for the new flag.

[2025-11-13T15:52:28Z] =========================== short test summary info ============================
[2025-11-13T15:52:28Z] FAILED schema_tests/test_dagster_daemon.py::test_daemon_command_with_user_deployments - AssertionError: assert ['/bin/bash', '-c', 'dagster-daemon run -w /dagster-workspace/workspace.yaml --log-format colored'] == ['/bin/bash', '-c', 'dagster-daemon run -w /dagster-workspace/workspace.yaml']
[2025-11-13T15:52:28Z]
[2025-11-13T15:52:28Z]   At index 2 diff: 'dagster-daemon run -w /dagster-workspace/workspace.yaml --log-format colored' != 'dagster-daemon run -w /dagster-workspace/workspace.yaml'
[2025-11-13T15:52:28Z]
[2025-11-13T15:52:28Z]   Full diff:
[2025-11-13T15:52:28Z]     [
[2025-11-13T15:52:28Z]         '/bin/bash',
[2025-11-13T15:52:28Z]         '-c',
[2025-11-13T15:52:28Z]   -     'dagster-daemon run -w /dagster-workspace/workspace.yaml',
[2025-11-13T15:52:28Z]   ?                                                              -
[2025-11-13T15:52:28Z]   +     'dagster-daemon run -w /dagster-workspace/workspace.yaml --log-format '
[2025-11-13T15:52:28Z]   ?                                                             ++++++++++++++
[2025-11-13T15:52:28Z]   +     'colored',
[2025-11-13T15:52:28Z]     ]
[2025-11-13T15:52:28Z] FAILED schema_tests/test_dagster_daemon.py::test_daemon_command_without_user_deployments - AssertionError: assert ['/bin/bash', '-c', 'dagster-daemon run --log-format colored'] == ['/bin/bash', '-c', 'dagster-daemon run']
[2025-11-13T15:52:28Z]
[2025-11-13T15:52:28Z]   At index 2 diff: 'dagster-daemon run --log-format colored' != 'dagster-daemon run'
[2025-11-13T15:52:28Z]
[2025-11-13T15:52:28Z]   Full diff:
[2025-11-13T15:52:28Z]     [
[2025-11-13T15:52:28Z]         '/bin/bash',
[2025-11-13T15:52:28Z]         '-c',
[2025-11-13T15:52:28Z]   -     'dagster-daemon run',
[2025-11-13T15:52:28Z]   +     'dagster-daemon run --log-format colored',
[2025-11-13T15:52:28Z]     ]
[2025-11-13T15:52:28Z] ================== 2 failed, 245 passed in 168.01s (0:02:48) ===================

@CrispyCrafter
Copy link
Author

Thanks @CrispyCrafter, it looks like it's defaulting to providing the --log-format colored flag which is causing a couple of tests to fail. You could either update your changes so that it defaults to no flag (probably cleanest), or update the tests to accommodate for the new flag.

Yeah defaulting to no value if not set makes sense.
Let me make the change

@CrispyCrafter
Copy link
Author

@cmpadden unit tests passed locally. Should be good to proceed now

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CrispyCrafter, just one final formatting change to remove the trailing slashes. We have a check that prettier runs on YAML files (eg. make prettier in the root of the repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants