-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(helm): Enable json log-formatting #32802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tting fix(helm): Implement conditional log-formatting
fix(helm): Expose optional replica-count
Patch json schema
Remove deamon replica-count
|
Thanks @CrispyCrafter, it looks like it's defaulting to providing the |
Yeah defaulting to no value if not set makes sense. |
|
@cmpadden unit tests passed locally. Should be good to proceed now |
cmpadden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CrispyCrafter, just one final formatting change to remove the trailing slashes. We have a check that prettier runs on YAML files (eg. make prettier in the root of the repository).
Co-authored-by: colton <[email protected]>
Co-authored-by: colton <[email protected]>
Summary & Motivation
This PR extends the existing functionality of both
dagster-webserveranddagster-daemonhelm templates by unlocking the ability to select the logformat generated by either service. This is especially helpful when integrating with third-party logging services such as DataDog and Loki.How I Tested These Changes
Changes tested and rolled out in live production environment.