fix: partition before default-range URL order #32798
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixed a bug where clicking a partition in
AssetPartitionListplaced default_range before partition in the URL, causing the purple overlay to expand incorrectly. The URL parameter order wasn't controlled, so default_range could appear before partition. This broke the overlay behavior. The fix ensures partition always comes before default_range in the URL, restoring correct overlay behavior.How I Tested These Changes
I tested the changes locally by running both the backend and frontend. For the backend, I launched the Dagster GraphQL server using time_based_partitioning.py, static_partitioning.py and files like those using dagster dev -f time_based_partitioning.py -p 3333 for example. For the frontend, I ran the Dagster UI using make dev_webapp. And the Verified Outcomes:
Fixed a bug where clicking a partition in the list put default_range before partition in the URL, which made the purple overlay expand incorrectly. The issue was that the code didn't control the order of URL parameters. Added logic to always place partition before default_range when building URLs, so the overlay behaves correctly.
Don't worry about code format, I did
yarn lint,yarn tsandyarn jestwithinui-coreto pick up lint fixesResolves "View Partitions" features at asset sidebar #32796