Merged
Conversation
SSM agents use smux streams for port forwarding. Implement basic smux protocol functionality and update the port forwarding plugin to use it.
Make sure both the README and implementation plan docs are updated to reflect that port forwarding is implemented.
This was a test tweak that didn't end up doing anything useful.
SSM Agents have been using smux for port forwarding communication since the beginning, and documentation that suggests it depends on a specific version range isn't useful.
Owner
|
Looks good, tested locally, much appreciated! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey thanks for creating this project! I had a use for mucking with port forwarding specifically, so scratched my own itch by filling in the stubbed out support you had here.
I'm opening this in case it'd be useful to pull any of the changes back upstream, but this is an unsolicited code dump so feel free to consider it junk mail 😁