Skip to content

Build updates for API 34 + Flutter 3.24#29

Merged
daadu merged 3 commits intodaadu:masterfrom
kee-org:master
Feb 18, 2025
Merged

Build updates for API 34 + Flutter 3.24#29
daadu merged 3 commits intodaadu:masterfrom
kee-org:master

Conversation

@luckyrat
Copy link
Copy Markdown
Collaborator

@luckyrat luckyrat commented Aug 9, 2024

These 3 commits were necessary for me to get the plugin to be included in a Release build targeting API 34 and Flutter 3.24. I saw no errors in a debug build but didn't thoroughly test functionality that depends on this plugin before finding that the apk build failed in release mode. I haven't tested any older API or Flutter versions.

I'm not 100% sure every change was needed in the end but it is working for me so I thought might be useful for others and if there are no problems with backwards compatibility, could potentially be merged in for a future release.

If there are any backwards compatibility problems you're bothered about, feel free to close the PR or ask for changes.

I've not migrated the plugin to the new Flutter Gradle declarative plugins block but have done that for other plugins recently so let me know if you'd like me to work on a follow-up PR with that change later.

Edit: In case it helps others find this, the build error that led me down this path was along the lines of "AAPT: error: resource android:attr/lStar not found."

@Ansis100
Copy link
Copy Markdown

Please merge this, the package literally breaks compilation of the entire app because of this issue.

@jakusb
Copy link
Copy Markdown

jakusb commented Oct 31, 2024

@daadu : Please consider this Pull Request or make a similar one that solves this issue.
My project breaks now without proper workaround. Thanks

@daadu daadu merged commit 67157a6 into daadu:master Feb 18, 2025
@daadu
Copy link
Copy Markdown
Owner

daadu commented Feb 18, 2025

The fix has landed on pub.dev with v0.2.6 along with #33

@daadu
Copy link
Copy Markdown
Owner

daadu commented Feb 18, 2025

@luckyrat Sorry for the unresponsiveness. I am no longer using this package for my project. If you are using it, then let me know if you are interested in being the co-maintainer of the package. Already sent an invite for the repo.

@luckyrat
Copy link
Copy Markdown
Collaborator Author

Thanks @daadu. I've accepted the invite and will help if I can the next time something like this comes up. No promises but I will try to keep on top of anything that breaks with new API or Flutter releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants