Decouple alignment from cacheline size #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the cacheline-size padding between class members is to avoid false sharing when threads modify the atomic members, but they do not have to be aligned exactly to the cacheline-size. The atomic members are very small (just 4 or 8 bytes) compared to the cacheline. As far as I can tell, their explicit alignment does not matter, they can be placed anywhere on the cacheline - we just need to ensure they are mapped to different cachelines. To avoid problems with misaligned dynamic allocation, the alignment must not be stricter than alignof(std::max_align_t), which is 16 bytes on x86_64 Linux. The value was added to the traits structs. Fixes d36u9#1
- use std::size_t instead of size_t and std::uint64_t instead of uint64_t - avoid useless static_cast<int> with an argument of the type int - avoid useless creation of std::vector<bool> which was used only for counting iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes #1. Also added another commit with some style changes/fixes.