Skip to content

Change errors to hash with indifference #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeanHealy33 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change errors to hash with indifference #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mutations/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def message_list
# state: ErrorAtom(:in)
# }
# }
class ErrorHash < Hash
class ErrorHash < HashWithIndifferentAccess

# Returns a nested HashWithIndifferentAccess where the values are symbols. Eg:
# {
Expand Down
16 changes: 16 additions & 0 deletions spec/errors_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,22 @@ def execute
end
end

describe "errors can be accessed as strings and symbolicly" do
class Foo < Mutations::Command
def execute
add_error(:foo, :bar, "baz")
end
end
let(:outcome){ Foo.run }

it{ assert(outcome.errors["foo"]) }
it{ assert(outcome.errors[:foo]) }
it{ assert_equal(outcome.errors["foo"].message, "baz") }
it{ assert_equal(outcome.errors[:foo].message, "baz") }

end


describe "Bunch o errors" do
before do
@outcome = GivesErrors.run(:str1 => "", :str2 => "opt9", :int1 => "zero", :hash1 => {:bool1 => "bob"}, :arr1 => ["bob", 1, "sally"])
Expand Down