Experimental fast visibility #6337
Open
+213
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cypress-documentation
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-documentation
|
| Branch Review |
experimental-fast-visibility
|
| Run status |
|
| Run duration | 05m 23s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
311
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
10.67%
|
|
|---|---|
|
Untested elements
|
2546
|
|
Tested elements
|
3
|
Accessibility
97.2%
|
|
|---|---|
|
Failed rules
|
1 critical
3 serious
4 moderate
0 minor
|
|
Failed elements
|
27
|
jennifer-shehane
approved these changes
Dec 10, 2025
AtofStryker
approved these changes
Dec 11, 2025
| #### An element is considered hidden if: | ||
|
|
||
| - Its `width` or `height` is `0`. | ||
| - Its CSS property (or ancestors) is `visibility: hidden`. |
Contributor
There was a problem hiding this comment.
More of a nit but this reads kind of strange to me since elements can have multiple properties? Feel free to ignore this since you are just moving the section 😅
Suggested change
| - Its CSS property (or ancestors) is `visibility: hidden`. | |
| - It (or ancestors) has CSS property `visibility: hidden`. |
| hidden when | ||
| [asserting on the element's visibility directly](/app/references/assertions#Visibility). | ||
|
|
||
| However elements where the CSS property (or ancestors) is `opacity: 0` are |
Contributor
There was a problem hiding this comment.
Suggested change
| However elements where the CSS property (or ancestors) is `opacity: 0` are | |
| However, elements where the CSS property (or ancestors) is `opacity: 0` are |
|
|
||
| #### Limitations | ||
|
|
||
| Experimental fast visibility is an experimental feature that is still under development. It is not yet fully compatible with the legacy visibility algorithm. |
Contributor
There was a problem hiding this comment.
does this imply that we are trying to achieve backwards compatibility at some point?
|
|
||
| The fast visibility algorithm provides several advantages over the legacy algorithm: | ||
|
|
||
| - **Better performance**: Constant-time in the best case, and bounded exponential in the worst case (when point sampling on a fully hidden element) |
Contributor
There was a problem hiding this comment.
Do we know how this compares directly to the current algorithm or is determining complexity for that incredibly challenging to distill briefly?
|
|
||
| :::caution | ||
|
|
||
| The experimental fast visibility algorithm is not yet fully compatible with the legacy visibility algorithm. Tests that rely on edge-case behavior of the legacy visibility algorithm may fail or behave incorrectly. |
Contributor
There was a problem hiding this comment.
This transition feels awkward but I don't love my suggestion.
Suggested change
| The experimental fast visibility algorithm is not yet fully compatible with the legacy visibility algorithm. Tests that rely on edge-case behavior of the legacy visibility algorithm may fail or behave incorrectly. | |
| The experimental fast visibility algorithm is not yet fully compatible with the legacy visibility algorithm. Tests that rely on edge-case behavior of the legacy visibility algorithm may fail or behave incorrectly. Remember, following apply to the experimental fast visibility algorithm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the visibility section in "interacting with elements" to include the "fast" visibility algorithm heuristics/semantics. Cross-references with links, and links to the main github issue tracking this experiment.