Skip to content

Conversation

@emilmilanov
Copy link
Contributor

image

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025

🦋 Changeset detected

Latest commit: a2fca8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cypress-design/react-icon Minor
@cypress-design/vue-icon Minor
@cypress-design/icon-registry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ✅ Ready (Inspect) Visit Preview Jun 23, 2025 2:38pm

@cypress
Copy link

cypress bot commented Jun 23, 2025

cypress-design    Run #3034

Run Properties:  status check passed Passed #3034  •  git commit d5dc62c6a1 ℹ️: Merge a2fca8f2e79f61e2163cd52ff897a3ea04528803 into 3093a1fac5802e6716c411b093a0...
Project cypress-design
Branch Review icon-ai-disabled-x16
Run status status check passed Passed #3034
Run duration 02m 46s
Commit git commit d5dc62c6a1 ℹ️: Merge a2fca8f2e79f61e2163cd52ff897a3ea04528803 into 3093a1fac5802e6716c411b093a0...
Committer Emil Milanov
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 236
View all changes introduced in this branch ↗︎
UI Coverage  7.43%
  Untested elements 308  
  Tested elements 26  
Accessibility  99.43%
  Failed rules  0 critical   2 serious   0 moderate   1 minor
  Failed elements 23  

<path d="M12.2485 5.99628L14.439 7.09198C15.1866 7.46618 15.1868 8.53426 14.439 8.90839L12.2485 10.0041C11.2773 10.4897 10.49 11.277 10.0044 12.2482L8.90869 14.4387C8.53468 15.1866 7.46651 15.1865 7.09229 14.4387L5.99658 12.2482C5.98295 12.221 5.96772 12.1941 5.95361 12.1672L7.41553 10.7053C7.54939 10.9141 7.6739 11.1302 7.78564 11.3537L8.00049 11.7834L8.21533 11.3537C8.89448 9.99542 9.99572 8.89417 11.354 8.21503L11.7837 8.00018L11.354 7.78534C11.1305 7.67361 10.9144 7.54907 10.7056 7.41522L12.1675 5.95331C12.1944 5.9674 12.2213 5.98266 12.2485 5.99628ZM7.09229 1.56171C7.44299 0.860329 8.40371 0.816021 8.83057 1.42987L8.90869 1.56171L10.0044 3.75214C10.0179 3.77912 10.0324 3.80552 10.0464 3.83221L8.58447 5.29413C8.4508 5.08555 8.32695 4.86987 8.21533 4.64667L8.00049 4.21698L7.78564 4.64667C7.10654 6.00487 6.00514 7.10618 4.64697 7.78534L4.21729 8.00018L4.64697 8.21503C4.87016 8.32664 5.08586 8.4505 5.29443 8.58417L3.83252 10.0461C3.80583 10.0321 3.77942 10.0176 3.75244 10.0041L1.56201 8.90839C0.813928 8.53432 0.813848 7.46606 1.56201 7.09198L3.75244 5.99628C4.72355 5.51065 5.51101 4.72328 5.99658 3.75214L7.09229 1.56171Z" fill="currentColor" class="icon-dark"/>
<path d="M2 14L14 2" stroke="#E45770" stroke-linecap="round"/>
</svg>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilmilanov There's a lot of line breaks at the end of this file for some reason. Typically this is something a linter would catch, so just something to look into.

Copy link
Contributor

@ryanjwilke ryanjwilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one minor comment for you. I would imagine that a linter would have caught that issue, but perhaps not.

@emilmilanov emilmilanov merged commit 946eed0 into main Jun 23, 2025
14 of 15 checks passed
@emilmilanov emilmilanov deleted the icon-ai-disabled-x16 branch June 23, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants