Skip to content

docs: Avoid topic clashes for ?mutate and other verbs - #2245

Draft
krlmlr wants to merge 14 commits into
mainfrom
f-help-topics
Draft

docs: Avoid topic clashes for ?mutate and other verbs#2245
krlmlr wants to merge 14 commits into
mainfrom
f-help-topics

Conversation

@krlmlr

@krlmlr krlmlr commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

@maelle: Looks like @noRd is the better choice here, need to remember that for duckplyr.

@aviator-app

aviator-app Bot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
krlmlr enabled auto-merge November 21, 2024 19:24
@krlmlr
krlmlr force-pushed the f-help-topics branch 2 times, most recently from c220f0d to fa9ed7a Compare November 21, 2024 20:20
@krlmlr
krlmlr disabled auto-merge November 21, 2024 20:20
@maelle

maelle commented Nov 22, 2024

Copy link
Copy Markdown
Member

@krlmlr why did you choose to stop re-exporting here, should duckplyr also stop re-exporting?

@krlmlr

krlmlr commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator Author

Good question, not sure yet. On the upside, this problem is independent of the help pages.

@krlmlr

krlmlr commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot: Also add tidyr to the "depends". Ensure vignettes can be built.

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

@krlmlr I've opened a new pull request, #2377, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 4 commits February 21, 2026 12:32
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@krlmlr

krlmlr commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator Author

Revdepcheck failures are likely, I can't deal with it now. Also, depending on dplyr and tidyr feels wrong. The clean solution is to not reexport at all, and also to not depend. A coding agent can do this easily, downstream failures will be more difficult to handle but can typically be fixed with one or two lines of code.

@krlmlr
krlmlr marked this pull request as draft February 21, 2026 15:35
@krlmlr krlmlr self-assigned this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants