Skip to content

Clarify Data View #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChrisPaulBennett
Copy link
Contributor

#2181
This pull request address's issue raised in issue #2181.
It adds a simple closeable chip up by the filers that informs the user that the analysis tab only shows successful tasks

Check List

  • [x ] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@ChrisPaulBennett ChrisPaulBennett self-assigned this Jun 16, 2025
@ChrisPaulBennett ChrisPaulBennett added the data workflows team Work pertaining to the analysis/gantt/etc views label Jun 16, 2025
@oliver-sanders oliver-sanders added this to the 2.8.0 milestone Jun 18, 2025
@oliver-sanders
Copy link
Member

The user who requested clarification was confused over the scope of the data (i.e. what cycles are we looking at).

Suggestion:

diff --git a/src/views/Analysis.vue b/src/views/Analysis.vue
index 0b6e461a..bb7eaa5a 100644
--- a/src/views/Analysis.vue
+++ b/src/views/Analysis.vue
@@ -108,11 +108,15 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
             <v-icon :icon="$options.icons.mdiRefresh" />
             <v-tooltip>Refresh data</v-tooltip>
           </v-btn>
+          <v-btn>
+            <v-icon :icon="$options.icons.mdiInformationOutline" />
+            <v-tooltip>
+              The Analysis View shows data for all succeeded jobs in all cycles
+              of the workflow.
+            </v-tooltip>
+          </v-btn>
         </v-defaults-provider>
         <!-- Box plot sort input teleports here -->
-        <v-chip closable>
-          The Analysis View only shows successful tasks.
-        </v-chip>
       </div>
       <AnalysisTable
         v-if="chartType === 'table'"
@@ -163,6 +167,7 @@ import {
 import {
   mdiChartTimeline,
   mdiChartTimelineVariant,
+  mdiInformationOutline,
   mdiRefresh,
   mdiTable,
 } from '@mdi/js'
@@ -352,6 +357,7 @@ export default {
   icons: {
     mdiChartTimeline,
     mdiChartTimelineVariant,
+    mdiInformationOutline,
     mdiRefresh,
     mdiTable,
   },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data workflows team Work pertaining to the analysis/gantt/etc views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants