Xtriggers and task run mode in info view #2102

wxtim · 2025-03-12T13:02:45Z

Requires cylc/cylc-flow#6671 [MERGED]

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
Tests are included (or explain why tests are not needed).
Changelog entry included if this is a change that can affect users
Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

wxtim · 2025-04-08T09:12:11Z

Note to self - remove the note from cylc doc added in cylc/cylc-doc#816 about info view not showing xtriggers.

wxtim · 2025-05-01T07:35:44Z

PR is ready for review, but only works in combination with cylc/cylc-flow#6671

tests/e2e/specs/info.cy.js

hjoliver · 2025-05-23T04:19:31Z

(I've started looking at this one)

oliver-sanders · 2025-05-23T08:53:02Z

(I've started looking at this one)

For context, task filtering based on xtrigger-derived state & task icon badges will follow in future PRs, this one is just about the info view.

src/components/cylc/Info.vue

tests/e2e/specs/info.cy.js

oliver-sanders · 2025-06-10T12:01:42Z

Something is going wrong with the trigger time field:

And what's up with the sort order? Why is the latest xtrigger in the middle?

src/components/cylc/Info.vue

oliver-sanders · 2025-06-10T12:08:23Z

LGTM, small issue with xtrigger sorting and trigger time calculation.

Note, we could just replace the trigger_time field in the xtriggers signature with the ISO8601 value to avoid adding an extra column (that only applies to @clock triggers).

src/components/cylc/Info.vue

tests/e2e/specs/info.cy.js

src/components/cylc/Info.vue

wxtim · 2025-06-19T09:53:29Z

Something is going wrong with the trigger time field:

I've removed seconds. Forgot about retry triggers when I did that. Thought that minutes would be fine.

And what's up with the sort order? Why is the latest xtrigger in the middle?

I've done nothing to sort the items. I imagine accidentally shearing seconds off them won't help. It seems to have sorted itself out in the process of fixing the other issues.

oliver-sanders · 2025-06-20T09:36:51Z

The re-formatted trigger-time field looks great.

The xtriggers are still being displayed in the order the backend provides them in which is unsorted. Not a biggie, but I think it would be good for the info view to sort by label, then signature.

Show wall_clock Trigger time in Z time. * Use v-table for xtriggers * Get rid of the trigger time column and modify the trigger_time to ISO in place * Remove unwanted css add sorting for xtriggers update test to reflect sort

MetRonnie · 2025-07-01T11:36:56Z

src/components/cylc/Info.vue

+              </tr>
+            </thead>
+            <tbody>
+              <tr v-for="xt in xtriggers" :key="xt">


key is supposed to be a primitive like string or number - https://vuejs.org/api/built-in-special-attributes.html#key

Suggested change

<tr v-for="xt in xtriggers" :key="xt">

<tr v-for="xt in xtriggers" :key="xt.id">

MetRonnie · 2025-07-01T11:41:37Z

src/components/cylc/Info.vue

+      const xtriggers = this.task?.node?.xtriggers
+      xtriggers.forEach(xtrigger => {
+        if (xtrigger.satisfied === true) {
+          xtrigger.satisfactionIcon = mdiCheckboxOutline
+        } else {
+          xtrigger.satisfactionIcon = mdiCheckboxBlankOutline
+        }


This is mutating the task prop, which should be avoided as it could lead to confusing behaviour.

Edit: seeing as I'm looking at this, I've addressed it quickly: wxtim#7

MetRonnie · 2025-07-01T11:50:28Z

tests/e2e/specs/info.cy.js

+      .get('.c-info .v-expansion-panel:nth-child(4)')
+      .find('button')
+      .click({ force: true })
+      .get('.v-expansion-panel--active')
+      .should('have.length', 4)
+
+      .get('.c-info .v-expansion-panel:nth-child(5)')
+      .find('button')
+      .click({ force: true })
+      .get('.v-expansion-panel--active')
+      .should('have.length', 5)
+
+      .get('.c-info .v-expansion-panel:nth-child(6)')
+      .find('button')
+      .click({ force: true })
+      .get('.v-expansion-panel--active')
+      .should('have.length', 6)


What's the use in testing the same mechanism repeatedly? Better to test that clicking the expansion panel titled "prerequisites" leads to a prerequisite task being visible and so on?

Edit: #2102 (comment) was marked as resolved but is not?

wxtim self-assigned this Mar 12, 2025

This comment was marked as resolved.

Sign in to view

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from a7d0e0a to 8e4dc72 Compare March 18, 2025 10:33

wxtim requested review from oliver-sanders and MetRonnie March 18, 2025 10:35

wxtim marked this pull request as draft March 18, 2025 10:43

wxtim mentioned this pull request Mar 31, 2025

xtrigger: ui support cylc/cylc-flow#6671

Merged

18 tasks

wxtim mentioned this pull request Apr 8, 2025

troubleshooting: flesh out the why are tasks waiting section cylc/cylc-doc#816

Merged

1 task

oliver-sanders mentioned this pull request Apr 24, 2025

set command: manually satisfy dependence on xtriggers cylc/cylc-flow#6695

Merged

8 tasks

wxtim marked this pull request as ready for review May 1, 2025 07:35

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from 077f8cd to 73a93e2 Compare May 1, 2025 07:51

This comment was marked as resolved.

Sign in to view

wxtim marked this pull request as draft May 13, 2025 09:31

This comment was marked as resolved.

Sign in to view

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from 73a93e2 to 0356607 Compare May 16, 2025 15:22

wxtim marked this pull request as ready for review May 19, 2025 07:07

wxtim commented May 19, 2025

View reviewed changes

tests/e2e/specs/info.cy.js Show resolved Hide resolved

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from 0356607 to b5be56b Compare May 19, 2025 07:20

oliver-sanders requested review from hjoliver and removed request for MetRonnie May 21, 2025 08:48

MetRonnie reviewed Jun 5, 2025

View reviewed changes

src/components/cylc/Info.vue Outdated Show resolved Hide resolved

tests/e2e/specs/info.cy.js Show resolved Hide resolved

oliver-sanders added this to the 2.8.0 milestone Jun 10, 2025

oliver-sanders reviewed Jun 10, 2025

View reviewed changes

src/components/cylc/Info.vue Outdated Show resolved Hide resolved

MetRonnie reviewed Jun 10, 2025

View reviewed changes

src/components/cylc/Info.vue Outdated Show resolved Hide resolved

src/components/cylc/Info.vue Outdated Show resolved Hide resolved

src/components/cylc/Info.vue Outdated Show resolved Hide resolved

tests/e2e/specs/info.cy.js Outdated Show resolved Hide resolved

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from d741ed5 to 6c5f082 Compare June 18, 2025 12:27

oliver-sanders changed the title ~~Xtriggers and mode in info view~~ Xtriggers and task run mode in info view Jun 18, 2025

oliver-sanders reviewed Jun 18, 2025

View reviewed changes

src/components/cylc/Info.vue Show resolved Hide resolved

wxtim requested review from oliver-sanders and MetRonnie June 19, 2025 09:53

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from c977b7c to 97c4037 Compare June 20, 2025 13:11

Show task state and xtriggers in the info view.

6478c48

Show wall_clock Trigger time in Z time. * Use v-table for xtriggers * Get rid of the trigger time column and modify the trigger_time to ISO in place * Remove unwanted css add sorting for xtriggers update test to reflect sort

wxtim force-pushed the feat.xtriggers_and_mode_info_view branch from 97c4037 to 6478c48 Compare June 20, 2025 13:26

oliver-sanders removed the request for review from hjoliver June 25, 2025 14:49

oliver-sanders approved these changes Jun 26, 2025

View reviewed changes

MetRonnie reviewed Jul 1, 2025

View reviewed changes

	<tr v-for="xt in xtriggers" :key="xt">
	<tr v-for="xt in xtriggers" :key="xt.id">

Xtriggers and task run mode in info view #2102

Are you sure you want to change the base?

Xtriggers and task run mode in info view #2102

Conversation

wxtim commented Mar 12, 2025 • edited by hjoliver Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

wxtim commented Apr 8, 2025

Uh oh!

wxtim commented May 1, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

hjoliver commented May 23, 2025

Uh oh!

oliver-sanders commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oliver-sanders commented Jun 10, 2025

Uh oh!

Uh oh!

oliver-sanders commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wxtim commented Jun 19, 2025

Uh oh!

oliver-sanders commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MetRonnie Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MetRonnie Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

MetRonnie Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wxtim commented Mar 12, 2025 •

edited by hjoliver

Loading

oliver-sanders commented May 23, 2025 •

edited

Loading

oliver-sanders commented Jun 20, 2025 •

edited

Loading