Skip to content

Conversation

@chigichan24
Copy link
Member

Issues

About

  • iconを変更
  • logoを変更
  • tool_bar_logoを変更
  • color がそのままだとキモかったので雰囲気で変更
  • minSdkApiを19から21に変更
    • 背景として,theme側でcolor等をいじるのがきつくなってきたため

scrrenshots

welcome

splash

login

top

search

room

@chigichan24
Copy link
Member Author

adaptive-output

@okaokahi
Copy link

okaokahi commented May 7, 2019

ログイン・新規登録の画面は、新規登録の文字が見えにくいので、文字色を#3B4043にしてください

@okaokahi
Copy link

okaokahi commented May 7, 2019

その他のボタンの文字色も同じく

@chigichan24
Copy link
Member Author

わかりました🙆‍♀️

@chigichan24
Copy link
Member Author

@okaokahi だいぶいい感じ😘

@mori-atsushi
Copy link
Collaborator

トップページのロゴ、ちょっと下げたほうが良さそう(svgの方を
編集したほうが楽かも)
yの飛び出てる部分分だけ上に上がってしまっている

@chigichan24
Copy link
Member Author

Toolbar logo looks nice 👀

Copy link
Collaborator

@mori-atsushi mori-atsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりましたが、ようやくコード見ました…!

override fun attachBaseContext(base: Context?) {
super.attachBaseContext(base)
MultiDex.install(this)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、なんで要らなくなったんだっけ。

<path
android:pathData="M61.54,8.65c0.49,-0.49 1.14,-0.82 1.63,-1.31A11.58,11.58 0,0 1,66.11 6a0.93,0.93 0,0 0,0.65 -1.15,0.94 0.94,0 0,0 -0.65,-0.65 13.53,13.53 0,0 0,-9.8 -0.33A22.37,22.37 0,0 0,27.74 6.68a22.77,22.77 0,0 0,-6.69 16A10.35,10.35 0,0 1,17 31a10.55,10.55 0,0 1,-13.06 -0.33l-0.16,-0.16A2.33,2.33 0,0 0,0 32.32,35 35,0 1,0 61.54,8.65ZM16.16,53.54s6.53,-29.22 18,-18C45.38,46.85 16.16,53.54 16.16,53.54ZM49.3,14a2.57,2.57 0,0 1,-2 1,3.38 3.38,0 0,1 -2.12,-0.82 3.15,3.15 0,0 1,-0.82 -2.12v-0.49a0.62,0.62 0,0 1,0.16 -0.49c0,-0.16 0.16,-0.33 0.33,-0.49s0.16,-0.33 0.33,-0.49a3.06,3.06 0,0 1,4.24 0,3.15 3.15,0 0,1 0.82,2.12A2.57,2.57 0,0 1,49.3 14Z"
android:fillColor="#FFFFFF"/>
</group>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あれ、これv24ついてないのと全く一緒だけどなんでいるんだっけ?

android:onClick="@{(v) -> viewModel.onSubmit()}"
android:text="@string/send_button"
android:textColor="@color/appWhite"
android:textColor="@color/on_beige_text"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ、スネークとキャメルが混じってるのウケるな。
このタイミングで全部スネークにしちゃうのが良さそう?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ロゴ・アイコンの差し替え

4 participants