Store JSON for things, collections, and user designs#22
Open
unknownlamer wants to merge 3 commits intocwoac:masterfrom
Open
Store JSON for things, collections, and user designs#22unknownlamer wants to merge 3 commits intocwoac:masterfrom
unknownlamer wants to merge 3 commits intocwoac:masterfrom
Conversation
added 3 commits
February 20, 2021 23:22
Dump raw JSON result from API request for better archiving.
|
This is a great idea. I'm not part of this project, but I've tried your changes in my own local copy and it works great. Thanks. |
Owner
|
Media goblin hosting is an interesting idea indeed. I'll take a look at this, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
I am looking at offline archiving my collections and designs from thingiverse, juuust in case, given its current state. To this end, I've started adding basic support for dumping the raw JSON details for things, collections, and the list of user designs. My hope is that sometime down the line this can be used by an importer to mediagoblin or something similar, or otherwise post-processed.
For now, it just unconditionally dumps the JSON (and doesn't do any checks for API errors to make sure it's actually returning the requested information), and dumps to "thing:$id.json", "collection:$id.json", or "designs:$username.json" mirroring how thingiverse labels them.
If this looks OK as a first pass, I was going to add some error checking code in the Grouping. If this looks OK generally, do you think it should be controlled with an argument? something like "--dump-json={all,designs,thing,collection}" maybe.