Skip to content

fix(basketball, football): handle transactions with missing items - #701

Merged
cwendt94 merged 1 commit into
cwendt94:masterfrom
Quadram13:fix/missing-transaction-items
Sep 14, 2026
Merged

fix(basketball, football): handle transactions with missing items#701
cwendt94 merged 1 commit into
cwendt94:masterfrom
Quadram13:fix/missing-transaction-items

Conversation

@Quadram13

Copy link
Copy Markdown
Contributor

Added the transaction item fallback from baseball to basketball and football.

- Default items to [] for transaction types that carry no items (matches baseball change at commit bf18c45)
@dtcarls

dtcarls commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Can confirm active bug I'm running into and having to work around. This seems simple enough and a quick fix.

@cwendt94

Copy link
Copy Markdown
Owner

thanks for the quick/simple fix!

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (cec2935) to head (2582528).

Files with missing lines Patch % Lines
espn_api/basketball/transaction.py 0.00% 1 Missing ⚠️
espn_api/football/transaction.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files          65       65           
  Lines        2710     2710           
=======================================
  Hits         2154     2154           
  Misses        556      556           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwendt94
cwendt94 merged commit 578137f into cwendt94:master Sep 14, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants