test if it is undefined against node, not null #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had stumbled upon the same bug and did exactly this fix. Please merge & release. |
|
@KeenS I am not sure what are you willing to test here.
|
|
I want to test this patch surely fix #39. You're right, this fix is obvious, but writing tests when you submit a patch is a good practice. |
|
Is there any plans to merge this PR? I'm facing the same issue here. |
|
ping @cvent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #39. As you cannot write undefined in JSON, I have no idea to test this patch. @sanjulr do you have any example?