Refactor init / RichMD.scoreQuarterLength / rm networkX - #1821
Merged
Conversation
These are not checked for unused modules, so they were not linted well. fixed
mscuthbert
changed the title
mscuthbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not checked for unused modules, so they were not linted well. fixed
rename RichMetadata.quarterLength to RichMetadata.scoreQuarterLength -- quarterLength refers to the length of the Metadata object itself (0.0) not information about the score!
Remove networkx capabilities -- untested since v1 (if not earlier) -- used to make some examples for music21's scale article and never used again.