Skip to content

Deduplicate strings in ip-ranges JSON #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byroot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deduplicate strings in ip-ranges JSON #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions actionpack-cloudfront.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.add_runtime_dependency 'actionpack', '>= 4.2'
spec.add_runtime_dependency 'railties', '>= 4.2'
spec.add_runtime_dependency 'json', '>= 2.4.0'
spec.add_development_dependency 'appraisal'
spec.add_development_dependency 'bundler'
spec.add_development_dependency 'rake'
Expand Down
4 changes: 2 additions & 2 deletions lib/action_pack/cloudfront/ip_ranges.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ def ip_data
Timeout.timeout(5) do
uri = URI('https://ip-ranges.amazonaws.com/ip-ranges.json')
res = Net::HTTP.get(uri)
JSON.parse(res)
JSON.parse(res, freeze: true)
end
rescue
backup_json = File.join File.dirname(__FILE__), 'ip-ranges.json'
JSON.parse File.read(backup_json)
JSON.load_file(backup_json, freeze: true)
end

extend self
Expand Down