Add EvalFuncVar binding via descriptor and drop manual rebinding #790
+61
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into #787 I found that
Enumoverrides__dir__, so dir(inst) insidecall_funcdoesn’t show the method.I went deep into MRO, inspect, etc., but the actual fix turned out to be much simpler: descriptors solve this problem.
CPython implementation
A quick search shows that
__dir__is rarely overridden, but this PR may also affect other class-related issues in Pyscript - I just don’t know which ones yet :)The logic for creating
EvalFuncVarClassInsthas also changed. Previously, anEvalFuncVarClassInstwas created for every availableEvalFuncVarmethod when the instance was constructed.Now, no
EvalFuncVarClassInstobjects are created during instance construction; instead, a newEvalFuncVarClassInstis created on each access to an EvalFuncVar.