refactor: un-hoist new Date() and static date usages - #145
refactor: un-hoist new Date() and static date usages#145google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Moved `new Date()` out of module-level scope in `app/sitemap.ts` to ensure fresh dates on execution. - Replaced module-level `CURRENT_YEAR` in `app/components/Footer/index.tsx` and `docs/app/[[...mdxPath]]/layout.tsx` to prevent stale copyright years in long-running processes. - Converted dynamic testing imports of `Footer` and `sitemap` to static imports in unit tests, now that fake timers naturally affect component render without module cache resets.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
1 participant
Addresses multiple code-health and performance issues noted in memory:
new Date()evaluation into the render/execution scope instead of module load time.await importandvi.resetModules()workarounds when testing components that depend on the current date.PR created automatically by Jules for task 11335851349421268746 started by @amrabed