HYACINTH-1169: Redirect after successful user or publish target creation#487
Open
wtomaszewska wants to merge 1 commit intofeature/HYACINTH-1164-new-publish-targets-frontendfrom
Conversation
…arget, display a success notification; adjust test utils to include notifications store; separate MutationAlerts into MutationSuccessAlert and MutationErrorAlert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket HYACINTH-1169
Overview
This PR is a follow-up to HYACINTH-1164. It modifies the existing create publish target and create user mutations so they:
One issue I encountered was the use of the
MutationAlertscomponent, which handles both success and error mutations. Since we still want to display creation errors on the page but use toasts for success, I split MutationAlerts into MutationErrorAlert and MutationSuccessAlert for more flexibility.