-
-
Notifications
You must be signed in to change notification settings - Fork 9
better error handling when loading tasks using esm #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
abendigo
wants to merge
6
commits into
main
Choose a base branch
from
marko/better-error-handling-esm-tasks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
02c3cb4
better error handling when loading tasks using esm
abendigo 498fa2b
dont try to compile the fixtures
abendigo f311e20
tell mocha to ignore the fixtures too
abendigo b976bf1
eslint needs to ignore fixtures as well
abendigo 9782378
make it work in Windows
abendigo 2fc4abe
Merge branch 'main' into marko/better-error-handling-esm-tasks
abendigo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[*] | ||
indent_size = 2 | ||
indent_style = space |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
test/fixtures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
{ | ||
"require": ["./env.js"], | ||
"extension": ["ts"], | ||
"recursive": true | ||
"recursive": true, | ||
"exclude": "test/fixtures/**", | ||
"node-option": [ | ||
"experimental-specifier-resolution=node", | ||
"loader=ts-node/esm" | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import assert = require('assert') | ||
import { Action, ActorWorld } from '../src' | ||
import type { IActorWorldOptions } from '../src/ActorWorld' | ||
import asyncAssignTasks from '../src/asyncAssignTasks' | ||
|
||
describe(asyncAssignTasks.name, () => { | ||
const options: IActorWorldOptions = { parameters: {} } as IActorWorldOptions | ||
|
||
// success | ||
it('successfully loads a task', async () => { | ||
class TestWorld extends ActorWorld { | ||
public goodtask: () => Action<void> | ||
} | ||
|
||
const world = new TestWorld(options) | ||
|
||
// Load the task | ||
await asyncAssignTasks(world, `${__dirname}/fixtures/tasks/goodtasks`) | ||
|
||
// Execute the task | ||
world.goodtask() | ||
}) | ||
|
||
// error compiling | ||
it('fails with a helpful error message if the task could not be compiled', async () => { | ||
class TestWorld extends ActorWorld { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need lines 26-30 for this test? |
||
public brokentask: () => Action<void> | ||
} | ||
|
||
const world = new TestWorld(options) | ||
|
||
// Try to load the task | ||
await assert.rejects(asyncAssignTasks(world, `${__dirname}/fixtures/tasks/brokentask`), { | ||
name: 'TSError', | ||
message: /Cannot find module '\.\/src'/, | ||
}) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// this import will fail | ||
import { type Action } from './src' | ||
|
||
export const badtask = (): Action => { | ||
// eslint-disable-next-line @typescript-eslint/no-empty-function | ||
return () => {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import { type Action } from '../../../../src' | ||
|
||
export const goodtask = (): Action<void> => { | ||
// eslint-disable-next-line @typescript-eslint/no-empty-function | ||
return () => {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand something here.
On line 12 we've defined
goodtask
as() => Action<void>
but that's also what's defined in thegoodtask.ts
fixture.Should we be using the result of this call to
asynAssignTasks
to set up thegoodtask
property on ourTestWorld
on line 12, instead of hard-coding / duplicating it?