Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

Multiple _animate bugfix#973

Open
glebmachine wants to merge 6 commits into
cubiq:masterfrom
glebmachine:master
Open

Multiple _animate bugfix#973
glebmachine wants to merge 6 commits into
cubiq:masterfrom
glebmachine:master

Conversation

@glebmachine

Copy link
Copy Markdown
Collaborator

Let me speak from my heart!

Very glad to made a pull request for iscroll)

This patch fixed annoying case:

iscroll.scrollTo(0,-500, 1000)
setTimeout(function(){
 iscroll.scrollTo(0,-2500, 1000) // this animation will ends on a half way, cause of first scroll make that.isAnimating was set to false and break all animations, created while first in progress.
}, 500)

@kaansoral

Copy link
Copy Markdown

Just inspected the code changes, looks great, I'm going to manually integrate this to my frankestein iscroll (too many manual modifications :)

@MichielDeMey

Copy link
Copy Markdown

+1 Nice to see a fix here! :)

@glebmachine

glebmachine commented Oct 9, 2015 via email

Copy link
Copy Markdown
Collaborator Author

@kaansoral

Copy link
Copy Markdown

I finally managed to test this on mobile devices too, iOS/Android - things seem much smoother now, thanks a lot for this improvement again

There was also rare crashes while scrolling, I think they might have been animations stacking, don't have enough experience to support this theory tho

@glebmachine

Copy link
Copy Markdown
Collaborator Author

up?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants