Skip to content

fix(schema-compiler): Preserve multiline values in YAML even in folding style #9912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(schema-compiler): Preserve multiline values in YAML even in folding style #9912

wants to merge 5 commits into from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Aug 21, 2025 •
edited
Loading

This PR adds a handy safeguard to change the folded style yaml multiline values (sql: > ) to literal style (sql: |) to preserve all line breaks.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review August 21, 2025 19:52
@KSDaemon KSDaemon requested a review from a team as a code owner August 21, 2025 19:52
@KSDaemon KSDaemon changed the title fix(schema-compiler): Preserve multiline values even in folding style fix(schema-compiler): Preserve multiline values in YAML even in folding style Aug 21, 2025
igorlukanin
igorlukanin requested changes Aug 25, 2025
View reviewed changes
Copy link
Member

@igorlukanin igorlukanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add CUBEJS_YAML_FOLDED_STRINGS_AS_LITERAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorlukanin igorlukanin igorlukanin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSDaemon @igorlukanin