-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(tesseract): Full key aggregate and logical plan refactoring #9807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9807 +/- ##
==========================================
+ Coverage 84.60% 84.61% +0.01%
==========================================
Files 253 253
Lines 89839 89874 +35
==========================================
+ Hits 76007 76046 +39
+ Misses 13832 13828 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4293241
to
7f69fbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge! 👍🏻 LGTM! Besides some typo/minor issues. Left some comments
packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/logical_plan/visitor/rewriter.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/logical_plan/logical_node.rs
Outdated
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/physical_plan_builder/context.rs
Outdated
Show resolved
Hide resolved
5c63235
to
a66770d
Compare
Check List