Skip to content

fix(api-gateway): Update shown: true to public : true in error messages #9756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

fix(api-gateway): Update shown: true to public : true in error messages #9756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/cubeorchestrator/src/query_result_transform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ pub fn get_members(
if !annotation.contains_key(member_name) {
bail!(
concat!(
"You requested hidden member: '{}'. Please make it visible using `shown: true`. ",
"Please note primaryKey fields are `shown: false` by default: ",
"You requested hidden member: '{}'. Please make it visible using `public: true`. ",
"Please note primaryKey fields are `public: false` by default: ",
"https://cube.dev/docs/schema/reference/joins#setting-a-primary-key."
),
column
Expand Down Expand Up @@ -344,8 +344,8 @@ pub fn get_vanilla_row(
None => {
bail!(
concat!(
"You requested hidden member: '{}'. Please make it visible using `shown: true`. ",
"Please note primaryKey fields are `shown: false` by default: ",
"You requested hidden member: '{}'. Please make it visible using `public: true`. ",
"Please note primaryKey fields are `public: false` by default: ",
"https://cube.dev/docs/schema/reference/joins#setting-a-primary-key."
),
alias
Expand Down
Loading