-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(tesseract): Rollup Join support #9745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9745 +/- ##
==========================================
+ Coverage 84.22% 84.26% +0.04%
==========================================
Files 231 232 +1
Lines 85494 86447 +953
==========================================
+ Hits 72005 72845 +840
- Misses 13489 13602 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be good. Left some minor neatpicks/comments...
...nner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/pre_aggregations_compiler.rs
Outdated
Show resolved
Hide resolved
...nner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/pre_aggregations_compiler.rs
Show resolved
Hide resolved
...nner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/pre_aggregations_compiler.rs
Show resolved
Hide resolved
...nner/cubesqlplanner/src/logical_plan/optimizers/pre_aggregation/pre_aggregations_compiler.rs
Show resolved
Hide resolved
rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/sql_call.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM!
Check List