Skip to content

fix(native): Handle null correctly as JsNull, not as JsString #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

ovr
Copy link
Member

@ovr ovr commented Jun 26, 2025

No description provided.

@ovr ovr requested a review from a team as a code owner June 26, 2025 13:09
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (40b3708) to head (3c049fa).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9717      +/-   ##
==========================================
+ Coverage   84.20%   84.32%   +0.11%     
==========================================
  Files         230      234       +4     
  Lines       85315    86954    +1639     
==========================================
+ Hits        71842    73321    +1479     
- Misses      13473    13633     +160     
Flag Coverage Δ
cubesql 84.32% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM just fix cargo fmt...

@ovr ovr merged commit 0523f7a into master Jul 17, 2025
82 checks passed
@ovr ovr deleted the fix/teserract-orchestrator-null-as-null branch July 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants