Add test app and fix Node.js compatibility#11
Merged
ctrlaltdylan merged 11 commits intomainfrom Feb 7, 2026
Merged
Conversation
- Add CLAUDE.md with project documentation and quick start guide - Add test-app/ - minimal Vite app to test App Bridge features (Modal, Toast, Session Token) - Fix Node.js version compatibility by downgrading vite and using esbuild - Fix modal store to handle showing modals without prior registration - Fix app-bridge script path in server (index.iife.js -> index.js) The test app demonstrates: - Loading mock App Bridge in iframe environment - Session token authentication via idToken() - Modal display via shopify.modal.show() - Toast notifications via shopify.toast.show() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ignore test screenshots and other png artifacts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update app-bridge modal feature to extract and sync HTML body content
- Update test-app to use proper Shopify App Bridge ui-modal pattern
- Modal now correctly displays title, body content, and action buttons
The test app demonstrates the correct pattern:
- Define <ui-modal id="my-modal"> with content and <ui-title-bar>
- Call shopify.modal.show('my-modal') to display
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create .github/workflows/publish.yml triggered on release - Builds all packages (root, admin-frame, app-bridge) - Publishes to NPM with public access for scoped package - Add publishConfig to package.json Requires NPM_TOKEN secret to be configured in repository settings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdwith project documentation and quick start guidetest-app/- minimal Vite app demonstrating App Bridge features (Modal, Toast, Session Token)Test App Features
The test app demonstrates the full testing flow:
shopify.idToken()shopify.modal.show()shopify.toast.show()How to Test
Based On
This branch is based on
spa-frame(PR #8) and includes all its changes plus the test app integration.🤖 Generated with Claude Code