Refactor SimTelFile to allow iterating over all events based
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
iter_all_events_2025
branch
from
310c8c4 to
48d7ca7
Compare
maxnoe
force-pushed
the
iter_all_events_2025
branch
from
7318873 to
1784b4e
Compare
Improve performance by removing the need to "peek" to the next object before parsing it by putting event building logic directly into `_parse_next_low_level`.
|
In the changes in 3e67777 I managed to remove most of the performance overhead the initial changes of this branch introduced. |
maxnoe
changed the title
SimTelFile to allow iterating over all events based
Closed
orelgueta
reviewed
Sep 8, 2025
|
And here are the corresponding changes needed in ctapipe to support iterating over also the non-triggered events: |
|
In case it was lost before: If you don't need me to look in detail at the assumed eventio structure, I can approve already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #214, due to the large changes in rebase, I didn't want to force-push over that branch but leave it for reference.