Issue #182 when scaling the cluster out, check joining nodes before finishing action #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced number of unnecessary sleep during tests
przysiadZeSztanga
approved these changes
Nov 14, 2025
|
@cscetbon @AKamyshnikova could you please review? |
Owner
|
/kuttl-tests |
cscetbon
reviewed
Nov 24, 2025
when scaling the cluster out, check joining nodes before finishing action Fixes cscetbon#182
sort pods by name ascending when choosing last pod from the slice
Contributor
Author
@cscetbon Do you mean I should execute those tests or write new scenario? I see there is a scenario for scale-up already |
Contributor
Author
Hi @cscetbon, I ran scaling kuttl test on my branch and it passed, see details below.
test logs |
cscetbon
approved these changes
Dec 2, 2025
Contributor
Author
|
Hi @cscetbon, thanks for approval! Can you merge it or we wait for other reviewers? |
Owner
|
@pchmieli until we make a release you won't be able to use this unless you use master or issue182 as the image tag. When do you need this out ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When scaling the cluster out, added check for joining nodes before finishing action (
ScaleOut=Done)Why?
To avoid setting cluster
Phase=Runningprecociously.Details in issue #182
Checklist