Skip to content

Fix literal parsing in legacy AST for older Solidity versions #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ep0chzer0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix literal parsing in legacy AST for older Solidity versions #2953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions slither/solc_parsing/expressions/expression_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,11 @@ def parse_expression(expression: dict, caller_context: CallerContextExpression)
else:
value = expression["attributes"].get("value", None)
if value:
# Fix for legacy AST: some older Solidity versions (e.g., 0.4.23) store
# numeric literals with embedded double-quotes like '"12"' instead of '12'
# Fixes: https://github.com/crytic/slither/issues/2215
if isinstance(value, str) and value.startswith('"') and value.endswith('"'):
value = value[1:-1]
if (
"subdenomination" in expression["attributes"]
and expression["attributes"]["subdenomination"]
Expand Down