Skip to content

mldsa: cleanup simd trait #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

franziskuskiefer
Copy link
Member

This is similar to the ml-kem change and gets rid of build warnings.

Also ignore F* extraction on git as long as we don't commit them.

Also ignore F* extraction on git as long as we don't commit them.
@franziskuskiefer franziskuskiefer requested a review from a team as a code owner May 21, 2025 05:48
Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Am a bit worried about proof disruption, but this will hopefully not affect the F* significantly.

@franziskuskiefer franziskuskiefer self-assigned this May 21, 2025
@franziskuskiefer franziskuskiefer added the do-not-merge Don't merge this PR label May 21, 2025
@franziskuskiefer
Copy link
Member Author

@karthikbhargavan what's the state of this. We need to get this in at some point.

@karthikbhargavan
Copy link
Contributor

Lets deal with it in the week of the 14th so that the current proofs can get reviewed before we change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants