Restructure C Code #1150
Restructure C Code #1150
Conversation
There was a problem hiding this comment.
Some thoughts
- Looking at this I'm not sure if
outis the best name for the actual code. Maybe something likegenerated? candcppare header only versions, whereas the new version from #1147 will generate C files. We could use the targets likeboringandnssas names. No strong opinion in any direction. Just wondering what the best naming scheme is.
keks
force-pushed
the
keks/restructure-c-code
branch
3 times, most recently
from
7b7f845 to
8e4985e
Compare
Darn, hadn't seen this earlier. I'll try to come up with something, might use generated.
I have no real opinions on the names, but what you suggest sounds reasonable. Do you mean we should rename c -> nss, cpp -> boring? I will make these changes tomorrow and squash them into this commit, so we have a clean base for the reviews afterwards. |
|
yeah target names would be nss (new C from #1147), openssh (now c) and boring (now cg). The nss (or new C) may be more generally interesting. Others too. That's why specific names may not be that great either. We could also use more specific names cpp_header_only (cg), c_header_only (c), c (new C) would be something more generic, but also longer. |
keks
force-pushed
the
keks/restructure-c-code
branch
from
99726b5 to
0bbfef3
Compare
use common c.sh, symlink update documentation ci: update needs names in C workflow mlkem: drop c-nss extract scripts ci: update more needs names Revert "ci: update more needs names" This reverts commit b2d6f85. ci: update needs of mlkem c status, but correct this time fix C/C++ extraction add mlkem.cmake symlink, move around version header kill script files ci: clean the right directory
keks
force-pushed
the
keks/restructure-c-code
branch
from
0bbfef3 to
80fcd8b
Compare
Closes #1148.
Closes #1049.