fix: skip missing extensions gracefully instead of crashing #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXTENSION_LIST in ProductionConfig includes optional extensions like liquidissuer that are not installed in source/development setups. Previously, a missing module raised SpecterError and prevented startup. Now logs a warning and continues loading the remaining extensions. This follows the principle that optional extensions should be optional. Fixes cryptoadvance#2496
✅ Deploy Preview for specter-desktop-docs canceled.
|
…e#2496) Two test cases: - Missing module in middle of list: skipped with warning, others load fine - All modules missing: returns empty list, no crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXTENSION_LISTinProductionConfigincludes optional extensions likeliquidissuerthat are not shipped with source installs. When any listed module is missing,get_classlist_of_type_clazz_from_modulelist()raises aSpecterErrorand prevents startup entirely.Fix: Replace the
raise SpecterError(...)withlogger.warning(...)+continue, so missing extensions are skipped with a clear log message while the rest of the application loads normally.Before:
After:
One-line logic change in
src/cryptoadvance/specter/util/reflection.py.Closes #2496