fix: guard spectrum_endpoint.wallets_get behind extension check #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Support Tools section in general_settings.jinja references spectrum_endpoint.wallets_get unconditionally, causing a BuildError when the Spectrum extension is not installed. Wrap the section in a Jinja conditional that checks whether the spectrum extension is loaded before rendering the link. Fixes cryptoadvance#2498
✅ Deploy Preview for specter-desktop-docs canceled.
|
…dvance#2498) Static template analysis tests that ensure: - All spectrum_endpoint references are inside a service_manager conditional - The guard block has a matching endif - The url_for call is within the guarded block Prevents regression: if someone removes the guard, tests catch it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Support Tools" section in
general_settings.jinjacallsurl_for('spectrum_endpoint.wallets_get')unconditionally. When the Spectrum extension is not installed (common in source installs), this causes a JinjaBuildErroron the settings page.Fix: Wrap the Support Tools block in
{% if "spectrum" in specter.service_manager.services %}so the link only renders when the extension is actually loaded.One-line template change, no Python changes needed.
Closes #2498