Skip to content

Conversation

@thomas-nguy
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner October 30, 2025 00:52
@thomas-nguy thomas-nguy requested review from XinyuCRO and randy-cro and removed request for a team October 30, 2025 00:52
@github-actions github-actions bot added the evm label Oct 30, 2025
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 8.05085% with 217 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.21%. Comparing base (3b1542d) to head (887a7ed).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
rpc/backend/mocks/evm_query_client.go 19.00% 53 Missing and 28 partials ⚠️
x/evm/keeper/grpc_query.go 0.00% 78 Missing ⚠️
rpc/backend/call_tx.go 0.00% 36 Missing ⚠️
rpc/backend/tx_info.go 0.00% 13 Missing ⚠️
rpc/namespaces/ethereum/eth/api.go 0.00% 5 Missing ⚠️
x/evm/types/tracer.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #768      +/-   ##
===========================================
- Coverage    46.84%   46.21%   -0.64%     
===========================================
  Files          189      189              
  Lines        15355    15565     +210     
===========================================
  Hits          7193     7193              
- Misses        7362     7548     +186     
- Partials       800      824      +24     
Files with missing lines Coverage Δ
rpc/backend/backend.go 77.77% <ø> (ø)
rpc/types/types.go 0.00% <ø> (ø)
x/evm/types/access_list.go 100.00% <ø> (ø)
x/evm/types/tracer.go 35.08% <0.00%> (-1.28%) ⬇️
rpc/namespaces/ethereum/eth/api.go 0.00% <0.00%> (ø)
rpc/backend/tx_info.go 56.70% <0.00%> (-2.66%) ⬇️
rpc/backend/call_tx.go 52.18% <0.00%> (-7.90%) ⬇️
x/evm/keeper/grpc_query.go 63.22% <0.00%> (-10.84%) ⬇️
rpc/backend/mocks/evm_query_client.go 44.28% <19.00%> (-12.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy force-pushed the thomas/access-list-support branch from 9eae520 to f4606c5 Compare October 30, 2025 05:52
return nil, 0, nil, err
}

prevTracer, traceArgs, err := b.initAccessListTracer(args, blockNum, addressesToExclude)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find the location that prevTracer wired into the EVM execution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean ?

res, err := b.DoCall(*traceArgs, blockNum, overrides

@thomas-nguy thomas-nguy force-pushed the thomas/access-list-support branch from af7fdfa to eb0d985 Compare December 4, 2025 07:38
@thomas-nguy thomas-nguy marked this pull request as draft December 5, 2025 02:37
@thomas-nguy thomas-nguy force-pushed the thomas/access-list-support branch from f00c1fb to b6c845d Compare December 6, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants