Skip to content

[DRAFT]fix: lastBlockList should be set at the end #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: release/v1.6.x
Choose a base branch
from
Draft

[DRAFT]fix: lastBlockList should be set at the end #1923

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40ba0d0
bugfix e2ee
thomas-nguy Nov 21, 2025
d1605c1
add changelog
thomas-nguy Nov 21, 2025
43a557e
return error at endblocker
thomas-nguy Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Bug fixes

* [#1918](https://github.com/crypto-org-chain/cronos/pull/1918) Chore: cleanup and improve x/mint params validation and test in cosmos-sdk
* [#1923](https://github.com/crypto-org-chain/cronos/pull/1911) Fix: LastBlockList should be set at the end

*Nov 30, 2025*

Expand Down
5 changes: 3 additions & 2 deletions app/proposal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ func (h *ProposalHandler) SetBlockList(blob []byte) error {
if bytes.Equal(h.lastBlockList, blob) {
return nil
}
h.lastBlockList = make([]byte, len(blob))
copy(h.lastBlockList, blob)

if len(blob) == 0 {
h.blocklist = make(map[string]struct{})
Expand Down Expand Up @@ -139,6 +137,9 @@ func (h *ProposalHandler) SetBlockList(blob []byte) error {
}

h.blocklist = m
h.lastBlockList = make([]byte, len(blob))
copy(h.lastBlockList, blob)

return nil
}

Expand Down
Loading