-
Notifications
You must be signed in to change notification settings - Fork 20
feat(storage): add configuration for external object storage provider #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e9ab0bd
scaffold out CRD properties for external object storage
andrewazores c0ad108
untested: rough out reconciler implementation for external S3 provider
andrewazores ee06414
regenerate
andrewazores d4d2d59
handle error (invalid config) cases
andrewazores ef4085b
set StorageURL from external S3 CR URL
andrewazores 163db29
correct external S3 tlsTrustAll env var value
andrewazores 5b46686
add test
andrewazores 32163df
do not set report sidecar storage auth when presigned transfers are e…
andrewazores 3b27d21
do not include BASIC_AUTH_KEY in generated storage secret
andrewazores 77c9da6
fixup! do not set report sidecar storage auth when presigned transfer…
andrewazores da34d9b
Apply suggestions
andrewazores b5cd255
only apply Storage TLS secret configuration if we're actually using i…
andrewazores 900149a
update
andrewazores 17f48da
add CRD spec for storage bucket names
andrewazores 0b455e3
include heapdumps and threaddumps buckets in cryostat-storage precrea…
andrewazores 9338542
implement handling for customized storage bucket names
andrewazores 4fe0ff4
fixup! include heapdumps and threaddumps buckets in cryostat-storage …
andrewazores f314472
fixup! implement handling for customized storage bucket names
andrewazores 3ccaed6
remove now-unused BASE_URI env var
andrewazores b38accb
only apply Storage TLS secret configuration to jfr-datasource if usin…
andrewazores 824638c
clean up unused resources when using external storage
andrewazores 7f5d4e4
doc, regen
andrewazores a9ba399
rename and invert property
andrewazores File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.