Fixed for ember 3 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastfedora
reviewed
Feb 18, 2018
addon/components/async-view.js
Outdated
| (typeof value.content !== 'undefined' ? value.content : undefined) : | ||
| value; | ||
| return value && typeof value.get('isPending') !== 'undefined' ? | ||
| (typeof value.content !== 'undefined' ? value.content : undefined) : |
Contributor
There was a problem hiding this comment.
Are all properties computed? If so, shouldn't these also be changed to value.get('content')?
fastfedora
reviewed
Feb 18, 2018
Contributor
fastfedora
left a comment
fastfedora
left a comment
There was a problem hiding this comment.
Do you know if this works in Ember 2.x, or is this Ember 3.x only?
Author
|
Updated the last getter. I haven't tested on ember two as all my projects are on v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties on promises are computed with ember 3. Use getters rather than raw accessor.