Allow Agent Daemonset Update Strategy#339
Open
macintoshme wants to merge 2 commits intocrowdsecurity:mainfrom
Open
Allow Agent Daemonset Update Strategy#339macintoshme wants to merge 2 commits intocrowdsecurity:mainfrom
macintoshme wants to merge 2 commits intocrowdsecurity:mainfrom
Conversation
Author
|
Is there a way I can facilitate this moving forward? Did I miss any documentation about PR? |
blotus
reviewed
Mar 22, 2026
Member
There was a problem hiding this comment.
I'm not sure we need to rename the parameter.
You cannot configure the agent to be a deployment and a daemonset at the same time, so I don't see the advantage of splitting the option in 2: the content of the parameter is passed as-is in the deployment, so the same could be done for the daemonset.
Additionally, renaming a config parameter is a breaking change, and we try to avoid them as much as possible.
- Consolidate deploymentStrategy and daemonsetStrategy back into single agent.strategy - Addresses reviewer concern about unnecessary renaming being a breaking change - Both Deployment and DaemonSet now use the same agent.strategy parameter - Follows existing pattern used by lapi.strategy and appsec.strategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this wasn't fleshed out and we could use it.
AI Slop generated by devstral2 and curated by a moron
/kind enhancement
/area agent