Skip to content

A Failure To DM Is Not A Total Failure #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A Failure To DM Is Not A Total Failure #58

wants to merge 1 commit into from

Conversation

phroggster
Copy link
Contributor

  • /submitbug and /submitfeature shouldn't send a failure message where unable to send a DM, especially if the user's DMs are closed:
    failed to DM
  • So tack on an ephemeral followUp noting that the DM failed to be sent, and call out where to track the issue progress at.
  • I do not like swallowing the error on the second followUp, but by then the first followUp with the ticket embed has already gone through, and the interaction has been resolved.
    • But it beats showing a failure message effectively stating "failed to notify you about failing to notify you".

This is completely untested.

@phroggster
A Failure To DM Is Not A Total Failure
e49fcaa 
- submitbug/submitfeature shouldn't send a failure message if unable to
  send a DM, especially if the user's DMs are closed.
- So tack on an ephemeral followUp noting that the DM failed to be sent,
  and call out where to track the issue progress at.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phroggster